bug in common/oml.c of osmo-bts?

Harald Welte laforge at gnumonks.org
Tue Jul 10 23:28:02 UTC 2012


Hi Andreas, sorry for the delayed response.  That mail got somehow
missed...

On Tue, Jul 03, 2012 at 08:55:50PM +0200, Andreas Eversberg wrote:

> rlcc->parameter[T_DL_TBF_EXT] = *(uint16_t *)cur * 10;
> rlcc->parameter[T_UL_TBF_EXT] = *(uint16_t *)cur * 10;
> 
> 1. isnt it * 2 instead of * 10? 

the parameter is coded in units of 10ms.  So in order to get from the
wire encoding to milliseconds, we need to multiply by 10.

> 2. did you forget ntoh(*(uint16_t *)cur)?

yes, it seems.  I've committed a fix now.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the osmocom-net-gprs mailing list