Change in ...osmo-sip-connector[master]: Add further logging.

keith gerrit-no-reply at lists.osmocom.org
Tue Jul 30 14:50:17 UTC 2019


keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997


Change subject: Add further logging.
......................................................................

Add further logging.

Log the IP port, payload type for calls.
Also log the SIP Call-ID, this help for correlation with SIP traces.

Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
---
M src/mncc.c
M src/sip.c
2 files changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/97/14997/1

diff --git a/src/mncc.c b/src/mncc.c
index 3f93126..5bd8af4 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -188,6 +188,8 @@
 	 * FIXME: mncc.payload_msg_type should already be compatible.. but
 	 * payload_type should be different..
 	 */
+	struct in_addr net = { .s_addr = other->ip };
+	LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port);
 	rc = write(leg->conn->fd.fd, &mncc, sizeof(mncc));
 	if (rc != sizeof(mncc)) {
 		LOGP(DMNCC, LOGL_ERROR, "Failed to send message leg(%u)\n",
diff --git a/src/sip.c b/src/sip.c
index 236c332..8f81a3f 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -98,7 +98,7 @@
 		return;
 	}
 
-	LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected.\n", leg);
+	LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected(%s).\n", leg, sip->sip_call_id->i_id);
 	leg->state = SIP_CC_CONNECTED;
 	other->connect_call(other);
 	nua_ack(leg->nua_handle, TAG_END());
@@ -111,7 +111,7 @@
 	struct sip_call_leg *leg;
 	const char *from = NULL, *to = NULL;
 
-	LOGP(DSIP, LOGL_DEBUG, "Incoming call handle(%p)\n", nh);
+	LOGP(DSIP, LOGL_DEBUG, "Incoming call(%s) handle(%p)\n", sip->sip_call_id->i_id, nh);
 
 	if (!sdp_screen_sdp(sip)) {
 		LOGP(DSIP, LOGL_ERROR, "No supported codec.\n");
@@ -158,6 +158,11 @@
 		call_leg_release(&leg->base);
 		return;
 	}
+	struct in_addr net = { .s_addr = leg->base.ip };
+	LOGP(DSIP, LOGL_DEBUG, "SDP Extracted: IP=(%s) PORT=(%u) PAYLOAD=(%u).\n",
+		               inet_ntoa(net),
+		               leg->base.port,
+		               leg->base.payload_type);
 
 	leg->base.release_call = sip_release_call;
 	leg->base.ring_call = sip_ring_call;
@@ -328,6 +333,7 @@
 			other->release_call(other);
 	} else if (event == nua_i_invite) {
 		/* new incoming leg or re-INVITE */
+		LOGP(DSIP, LOGL_NOTICE, "Processing INVITE Call-ID: %s\n", sip->sip_call_id->i_id);
 
 		if (status == 100) {
 			struct sip_call_leg *leg = sip_find_leg(nh);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
Gerrit-Change-Number: 14997
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/3404bb26/attachment.html>


More information about the gerrit-log mailing list