Change in ...osmo-sip-connector[master]: Add further logging.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 30 15:14:29 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )

Change subject: Add further logging.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 
PS1, Line 191: 	struct in_addr net = { .s_addr = other->ip };
Are you sure this is correct? or you need to use mncc.ip?


https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@192 
PS1, Line 192: 	LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port);
Better use inet_ntop().


https://gerrit.osmocom.org/#/c/14997/1/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14997/1/src/sip.c@163 
PS1, Line 163: 		               inet_ntoa(net),
Better use inet_ntop().



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
Gerrit-Change-Number: 14997
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 15:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/3eb3fd0d/attachment.html>


More information about the gerrit-log mailing list