<p>keith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add further logging.<br><br>Log the IP port, payload type for calls.<br>Also log the SIP Call-ID, this help for correlation with SIP traces.<br><br>Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b<br>---<br>M src/mncc.c<br>M src/sip.c<br>2 files changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/97/14997/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index 3f93126..5bd8af4 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -188,6 +188,8 @@</span><br><span>     * FIXME: mncc.payload_msg_type should already be compatible.. but</span><br><span>    * payload_type should be different..</span><br><span>         */</span><br><span style="color: hsl(120, 100%, 40%);">+   struct in_addr net = { .s_addr = other->ip };</span><br><span style="color: hsl(120, 100%, 40%);">+      LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port);</span><br><span>       rc = write(leg->conn->fd.fd, &mncc, sizeof(mncc));</span><br><span>         if (rc != sizeof(mncc)) {</span><br><span>            LOGP(DMNCC, LOGL_ERROR, "Failed to send message leg(%u)\n",</span><br><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index 236c332..8f81a3f 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -98,7 +98,7 @@</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected.\n", leg);</span><br><span style="color: hsl(120, 100%, 40%);">+        LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected(%s).\n", leg, sip->sip_call_id->i_id);</span><br><span>     leg->state = SIP_CC_CONNECTED;</span><br><span>    other->connect_call(other);</span><br><span>       nua_ack(leg->nua_handle, TAG_END());</span><br><span>@@ -111,7 +111,7 @@</span><br><span>        struct sip_call_leg *leg;</span><br><span>    const char *from = NULL, *to = NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        LOGP(DSIP, LOGL_DEBUG, "Incoming call handle(%p)\n", nh);</span><br><span style="color: hsl(120, 100%, 40%);">+   LOGP(DSIP, LOGL_DEBUG, "Incoming call(%s) handle(%p)\n", sip->sip_call_id->i_id, nh);</span><br><span> </span><br><span>    if (!sdp_screen_sdp(sip)) {</span><br><span>          LOGP(DSIP, LOGL_ERROR, "No supported codec.\n");</span><br><span>@@ -158,6 +158,11 @@</span><br><span>            call_leg_release(&leg->base);</span><br><span>                 return;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     struct in_addr net = { .s_addr = leg->base.ip };</span><br><span style="color: hsl(120, 100%, 40%);">+   LOGP(DSIP, LOGL_DEBUG, "SDP Extracted: IP=(%s) PORT=(%u) PAYLOAD=(%u).\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                         inet_ntoa(net),</span><br><span style="color: hsl(120, 100%, 40%);">+                               leg->base.port,</span><br><span style="color: hsl(120, 100%, 40%);">+                            leg->base.payload_type);</span><br><span> </span><br><span>       leg->base.release_call = sip_release_call;</span><br><span>        leg->base.ring_call = sip_ring_call;</span><br><span>@@ -328,6 +333,7 @@</span><br><span>                        other->release_call(other);</span><br><span>       } else if (event == nua_i_invite) {</span><br><span>          /* new incoming leg or re-INVITE */</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSIP, LOGL_NOTICE, "Processing INVITE Call-ID: %s\n", sip->sip_call_id->i_id);</span><br><span> </span><br><span>              if (status == 100) {</span><br><span>                         struct sip_call_leg *leg = sip_find_leg(nh);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997">change 14997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b </div>
<div style="display:none"> Gerrit-Change-Number: 14997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>