Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

keith gerrit-no-reply at lists.osmocom.org
Tue Jul 30 18:02:12 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )

Change subject: Add support for MNCC HOLD/RETRIEVE
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c@697 
PS3, Line 697: 		"leg(%u) is req unhold.\n", leg->callref);
> reason to call "retrieve" "unhold" all of a sudden? […]
My Nokia 6070 displays "Unhold" in the right hand bottom corner of the screen when the principal call is on hold.
I guess that took over my brain.. + I was writing code for the compiler and comments for humans.

I've never heard a human refer to "retrieve"-ing a call.

We say. "I'll just put you on hold" "take the call off hold" etc.. 
:-)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9
Gerrit-Change-Number: 14996
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 18:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/8448e731/attachment.html>


More information about the gerrit-log mailing list