[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Sun Mar 16 09:40:58 UTC 2014


Hi Holger,

it seems there are no more comments on this code. Could you please merge it?
It is independent of other changes.

On Wed, Mar 12, 2014 at 9:06 PM, Alexander Chemeris
<alexander.chemeris at gmail.com> wrote:
> On Wed, Mar 12, 2014 at 8:02 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
>> On Wed, 2014-03-12 at 19:53, Alexander Chemeris wrote:
>>> On Wed, Mar 12, 2014 at 6:59 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
>>> > looks all fine except for the function name. Something more expressive
>>> > would be nice - how about gsm340_validity_period_as_ts()?
>>>
>>> I'm not sure "as_ts" is really more expressive,
>>
>>> gsm340_validity_period_unix_time() would be more expressive, but it's
>>> also painfully long. I would suggest:
>>>  - gsm340_validity_time()
>>
>> I like that one.
>
> Updated
>
> --
> Regards,
> Alexander Chemeris.
> CEO, Fairwaves, Inc. / ООО УмРадио
> https://fairwaves.co



-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co




More information about the OpenBSC mailing list