[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Sun Mar 16 09:55:00 UTC 2014


On Sun, Mar 16, 2014 at 01:40:58PM +0400, Alexander Chemeris wrote:

Dear Alexander,

> it seems there are no more comments on this code. Could you please merge it?
> It is independent of other changes.

there is a fixed amount of time I can spend on review a week. You sadly
have used some of this time by sending not compiling patches, wrong ones,
etc. This means you will need to wait for my next timeslot.

The lack of comments doesn't mean that there will be none. E.g. in one
of the testcases I noticed that you don't use C99 initializers but the
old/error prone way of initializing. :)

holger

PS: I will not reply the same to all your other messages. ;)




More information about the OpenBSC mailing list