[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Wed Mar 12 17:06:29 UTC 2014


On Wed, Mar 12, 2014 at 8:02 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
> On Wed, 2014-03-12 at 19:53, Alexander Chemeris wrote:
>> On Wed, Mar 12, 2014 at 6:59 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
>> > looks all fine except for the function name. Something more expressive
>> > would be nice - how about gsm340_validity_period_as_ts()?
>>
>> I'm not sure "as_ts" is really more expressive,
>
>> gsm340_validity_period_unix_time() would be more expressive, but it's
>> also painfully long. I would suggest:
>>  - gsm340_validity_time()
>
> I like that one.

Updated

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sms-Proper-decoding-and-storage-of-SMS-validity-peri.patch
Type: text/x-patch
Size: 7966 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140312/e704ebb7/attachment.bin>


More information about the OpenBSC mailing list