[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Daniel Willmann dwillmann at sysmocom.de
Wed Mar 12 16:02:08 UTC 2014


On Wed, 2014-03-12 at 19:53, Alexander Chemeris wrote:
> On Wed, Mar 12, 2014 at 6:59 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
> > looks all fine except for the function name. Something more expressive
> > would be nice - how about gsm340_validity_period_as_ts()?
> 
> I'm not sure "as_ts" is really more expressive,

> gsm340_validity_period_unix_time() would be more expressive, but it's
> also painfully long. I would suggest:
>  - gsm340_validity_time()

I like that one.


Regards,
-- 
- Daniel Willmann <dwillmann at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte




More information about the OpenBSC mailing list