Change in osmo-pcu[master]: tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25632 )

Change subject: tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING
......................................................................

tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING

Fixes following error log line:
"{RELEASING}: Event DL_ACKNACK_MISS not permitted"

Rationale: We may move to RELEASING state at some point, for instance
due to MAX_N3101/MAX_N3105 while still having some active poll
registered in some PDCH ulc. Upon that poll (most probably) timing out,
it will send a DL_ACKNACK_MISS event to us. Since we are already
determined to release the TBF (waiting for T3195 or T3169 to trigger),
simply ignore the event and avoid logging an error.

Fixes: OS#5240
Change-Id: Ibfb49356d2b3b5fccb6d59db8593b2256e5c51fb
---
M src/tbf_fsm.c
1 file changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c
index be3c3ef..4202a0c 100644
--- a/src/tbf_fsm.c
+++ b/src/tbf_fsm.c
@@ -323,6 +323,18 @@
 	osmo_timer_schedule(&fi->timer, val, 0);
 }
 
+static void st_releasing(struct osmo_fsm_inst *fi, uint32_t event, void *data)
+{
+	switch (event) {
+	case TBF_EV_DL_ACKNACK_MISS:
+		/* Ignore, we don't care about missed DL ACK/NACK poll timeouts
+		 * anymore, we are already releasing the TBF */
+		break;
+	default:
+		OSMO_ASSERT(0);
+	}
+}
+
 static void handle_timeout_X2002(struct tbf_fsm_ctx *ctx)
 {
 	struct gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(ctx->tbf);
@@ -441,10 +453,11 @@
 	},
 	[TBF_ST_RELEASING] = {
 		.in_event_mask =
-			0,
+			X(TBF_EV_DL_ACKNACK_MISS),
 		.out_state_mask =
 			0,
 		.name = "RELEASING",
+		.action = st_releasing,
 		.onenter = st_releasing_on_enter,
 	},
 };

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb49356d2b3b5fccb6d59db8593b2256e5c51fb
Gerrit-Change-Number: 25632
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/7aeeed41/attachment.htm>