Change in osmo-ttcn3-hacks[master]: RSLEM: add f_rslem_auto_chan_act_ack(boolean)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Sep 28 16:48:14 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25633 )


Change subject: RSLEM: add f_rslem_auto_chan_act_ack(boolean)
......................................................................

RSLEM: add f_rslem_auto_chan_act_ack(boolean)

Allow to switch off automatic Channel Activation ACK via a new port
signature.

Required for upcoming BSC_Tests.TC_lost_sdcch_during_assignment().

Related: SYS#5627
Change-Id: I9a9d191aa66ec27f4f80c2baa2c5aa3c7b668d66
---
M library/RSL_Emulation.ttcn
1 file changed, 19 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/25633/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 31647df..6baa77f 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -98,11 +98,13 @@
 signature RSLEM_suspend(boolean suspend);
 signature RSLEM_wait_queue(boolean enable);
 signature RSLEM_get_last_act(in uint8_t trx_nr, in RslChannelNr chan_nr, out RSL_Message chan_act);
+signature RSLEM_auto_chan_act_ack(boolean enable);
 
 type port RSLEM_PROC_PT procedure {
 	inout RSLEM_register, RSLEM_unregister,
 	      RSLEM_suspend, RSLEM_wait_queue,
-	      RSLEM_get_last_act;
+	      RSLEM_get_last_act,
+	      RSLEM_auto_chan_act_ack;
 } with { extension "internal" };
 
 /***********************************************************************
@@ -491,6 +493,7 @@
 	 * in a queue. These messages will remain in the queue until the appropriate
 	 * connection handler is registered. */
 	var boolean wait_queue_enabled := false;
+	var boolean auto_chan_act_ack := true;
 
 	f_conn_table_init();
 	f_trx_conn_map_init();
@@ -599,7 +602,11 @@
 			chan_nr := rx_rsl.rsl.ies[0].body.chan_nr;
 			trx_nr := f_trx_by_streamId(rx_rsl.streamId);
 			f_store_last_act_data(trx_nr, chan_nr, rx_rsl.rsl);
-			IPA_PT.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_ACK(chan_nr, 23), rx_rsl.streamId));
+			if (auto_chan_act_ack) {
+				IPA_PT.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_ACK(chan_nr, 23), rx_rsl.streamId));
+			} else {
+				CLIENT_PT.send(rx_rsl);
+			}
 		}
 
 		[not dchan_suspended] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeDR(?), sid := ?)) -> value rx_rsl {
@@ -706,6 +713,10 @@
 			var RSL_Message last_chan_act := f_lookup_last_act(trx_nr, chan_nr);
 			RSL_PROC.reply(RSLEM_get_last_act:{trx_nr, chan_nr, last_chan_act}) to vc_conn;
 			}
+
+		[] RSL_PROC.getcall(RSLEM_auto_chan_act_ack:{?}) -> param(auto_chan_act_ack) sender vc_conn {
+			RSL_PROC.reply(RSLEM_auto_chan_act_ack:{auto_chan_act_ack}) to vc_conn;
+			}
 		}
 	}
 }
@@ -800,7 +811,11 @@
 	return chan_act;
 }
 
-
-
+function f_rslem_auto_chan_act_ack(RSLEM_PROC_PT PT, boolean enable)
+runs on RSL_DchanHdlr {
+	PT.call(RSLEM_auto_chan_act_ack:{enable}) {
+		[] PT.getreply(RSLEM_auto_chan_act_ack:{enable}) {};
+	}
+}
 
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25633
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a9d191aa66ec27f4f80c2baa2c5aa3c7b668d66
Gerrit-Change-Number: 25633
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/c89c5f85/attachment.htm>


More information about the gerrit-log mailing list