<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25633">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RSLEM: add f_rslem_auto_chan_act_ack(boolean)<br><br>Allow to switch off automatic Channel Activation ACK via a new port<br>signature.<br><br>Required for upcoming BSC_Tests.TC_lost_sdcch_during_assignment().<br><br>Related: SYS#5627<br>Change-Id: I9a9d191aa66ec27f4f80c2baa2c5aa3c7b668d66<br>---<br>M library/RSL_Emulation.ttcn<br>1 file changed, 19 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/25633/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn</span><br><span>index 31647df..6baa77f 100644</span><br><span>--- a/library/RSL_Emulation.ttcn</span><br><span>+++ b/library/RSL_Emulation.ttcn</span><br><span>@@ -98,11 +98,13 @@</span><br><span> signature RSLEM_suspend(boolean suspend);</span><br><span> signature RSLEM_wait_queue(boolean enable);</span><br><span> signature RSLEM_get_last_act(in uint8_t trx_nr, in RslChannelNr chan_nr, out RSL_Message chan_act);</span><br><span style="color: hsl(120, 100%, 40%);">+signature RSLEM_auto_chan_act_ack(boolean enable);</span><br><span> </span><br><span> type port RSLEM_PROC_PT procedure {</span><br><span>         inout RSLEM_register, RSLEM_unregister,</span><br><span>            RSLEM_suspend, RSLEM_wait_queue,</span><br><span style="color: hsl(0, 100%, 40%);">-        RSLEM_get_last_act;</span><br><span style="color: hsl(120, 100%, 40%);">+           RSLEM_get_last_act,</span><br><span style="color: hsl(120, 100%, 40%);">+           RSLEM_auto_chan_act_ack;</span><br><span> } with { extension "internal" };</span><br><span> </span><br><span> /***********************************************************************</span><br><span>@@ -491,6 +493,7 @@</span><br><span>    * in a queue. These messages will remain in the queue until the appropriate</span><br><span>          * connection handler is registered. */</span><br><span>      var boolean wait_queue_enabled := false;</span><br><span style="color: hsl(120, 100%, 40%);">+      var boolean auto_chan_act_ack := true;</span><br><span> </span><br><span>   f_conn_table_init();</span><br><span>         f_trx_conn_map_init();</span><br><span>@@ -599,7 +602,11 @@</span><br><span>                        chan_nr := rx_rsl.rsl.ies[0].body.chan_nr;</span><br><span>                   trx_nr := f_trx_by_streamId(rx_rsl.streamId);</span><br><span>                        f_store_last_act_data(trx_nr, chan_nr, rx_rsl.rsl);</span><br><span style="color: hsl(0, 100%, 40%);">-                     IPA_PT.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_ACK(chan_nr, 23), rx_rsl.streamId));</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (auto_chan_act_ack) {</span><br><span style="color: hsl(120, 100%, 40%);">+                              IPA_PT.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_ACK(chan_nr, 23), rx_rsl.streamId));</span><br><span style="color: hsl(120, 100%, 40%);">+                        } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                              CLIENT_PT.send(rx_rsl);</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span>            }</span><br><span> </span><br><span>                [not dchan_suspended] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeDR(?), sid := ?)) -> value rx_rsl {</span><br><span>@@ -706,6 +713,10 @@</span><br><span>                       var RSL_Message last_chan_act := f_lookup_last_act(trx_nr, chan_nr);</span><br><span>                         RSL_PROC.reply(RSLEM_get_last_act:{trx_nr, chan_nr, last_chan_act}) to vc_conn;</span><br><span>                      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           [] RSL_PROC.getcall(RSLEM_auto_chan_act_ack:{?}) -> param(auto_chan_act_ack) sender vc_conn {</span><br><span style="color: hsl(120, 100%, 40%);">+                      RSL_PROC.reply(RSLEM_auto_chan_act_ack:{auto_chan_act_ack}) to vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span>            }</span><br><span>    }</span><br><span> }</span><br><span>@@ -800,7 +811,11 @@</span><br><span>        return chan_act;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+function f_rslem_auto_chan_act_ack(RSLEM_PROC_PT PT, boolean enable)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on RSL_DchanHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+      PT.call(RSLEM_auto_chan_act_ack:{enable}) {</span><br><span style="color: hsl(120, 100%, 40%);">+           [] PT.getreply(RSLEM_auto_chan_act_ack:{enable}) {};</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25633">change 25633</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25633"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9a9d191aa66ec27f4f80c2baa2c5aa3c7b668d66 </div>
<div style="display:none"> Gerrit-Change-Number: 25633 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>