<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25632">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING<br><br>Fixes following error log line:<br>"{RELEASING}: Event DL_ACKNACK_MISS not permitted"<br><br>Rationale: We may move to RELEASING state at some point, for instance<br>due to MAX_N3101/MAX_N3105 while still having some active poll<br>registered in some PDCH ulc. Upon that poll (most probably) timing out,<br>it will send a DL_ACKNACK_MISS event to us. Since we are already<br>determined to release the TBF (waiting for T3195 or T3169 to trigger),<br>simply ignore the event and avoid logging an error.<br><br>Fixes: OS#5240<br>Change-Id: Ibfb49356d2b3b5fccb6d59db8593b2256e5c51fb<br>---<br>M src/tbf_fsm.c<br>1 file changed, 14 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c</span><br><span>index be3c3ef..4202a0c 100644</span><br><span>--- a/src/tbf_fsm.c</span><br><span>+++ b/src/tbf_fsm.c</span><br><span>@@ -323,6 +323,18 @@</span><br><span>   osmo_timer_schedule(&fi->timer, val, 0);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void st_releasing(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case TBF_EV_DL_ACKNACK_MISS:</span><br><span style="color: hsl(120, 100%, 40%);">+          /* Ignore, we don't care about missed DL ACK/NACK poll timeouts</span><br><span style="color: hsl(120, 100%, 40%);">+            * anymore, we are already releasing the TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void handle_timeout_X2002(struct tbf_fsm_ctx *ctx)</span><br><span> {</span><br><span>     struct gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(ctx->tbf);</span><br><span>@@ -441,10 +453,11 @@</span><br><span>  },</span><br><span>   [TBF_ST_RELEASING] = {</span><br><span>               .in_event_mask =</span><br><span style="color: hsl(0, 100%, 40%);">-                        0,</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(TBF_EV_DL_ACKNACK_MISS),</span><br><span>           .out_state_mask =</span><br><span>                    0,</span><br><span>           .name = "RELEASING",</span><br><span style="color: hsl(120, 100%, 40%);">+                .action = st_releasing,</span><br><span>              .onenter = st_releasing_on_enter,</span><br><span>    },</span><br><span> };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25632">change 25632</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25632"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibfb49356d2b3b5fccb6d59db8593b2256e5c51fb </div>
<div style="display:none"> Gerrit-Change-Number: 25632 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>