Change in osmo-gbproxy[master]: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Sep 24 15:02:40 UTC 2021


daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577 )


Change subject: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK
......................................................................

gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK

Don't answer with STATUS if the BVC referred to by the BLOCK_ACK is
unknown. This can happen when the BSS BVC disappears and the gbproxy
blocks and then removes the corresponding BVC at the SGSN.

Related: SYS#5628. OS#5236
Change-Id: Ic9f34a27412d6e15ca1198ee140f66a076b5c6b6
---
M src/gb_proxy.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/77/25577/1

diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index be075d6..37ccc11 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -1375,7 +1375,7 @@
 		bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI));
 		sgsn_bvc = gbproxy_bvc_by_bvci(nse, bvci);
 		if (!sgsn_bvc)
-			goto err_no_bvc;
+			break;
 		rc = osmo_fsm_inst_dispatch(sgsn_bvc->fi, BSSGP_BVCFSM_E_RX_BLOCK_ACK, msg);
 		break;
 	case BSSGP_PDUT_BVC_UNBLOCK_ACK:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ic9f34a27412d6e15ca1198ee140f66a076b5c6b6
Gerrit-Change-Number: 25577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210924/86399ae1/attachment.htm>


More information about the gerrit-log mailing list