This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25576 ) Change subject: gbproxy: Remove SGSN-side BVC after sending BVC-BLOCK ...................................................................... gbproxy: Remove SGSN-side BVC after sending BVC-BLOCK If we keep the bvc around the SGSN could send a BVC-RESET which the gbproxy would ACK. This will reestablish the BVC only between the gbproxy and SGSN which can lead to all sorts of issues. With this patch the gbproxy will respond with a BVC-STATUS cause BVCI unknown. Related: SYS#5628 Fixes: OS#5236 Change-Id: Ib14be6425a81b43353708b2708f79e035e501079 --- M src/gb_proxy.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 94ac4a3..be075d6 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1627,6 +1627,7 @@ /* Block BVC, indicate BSS equipment failure */ uint8_t cause = BSSGP_CAUSE_EQUIP_FAIL; osmo_fsm_inst_dispatch(sgsn_bvc->fi, BSSGP_BVCFSM_E_REQ_BLOCK, &cause); + gbproxy_bvc_free(sgsn_bvc); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib14be6425a81b43353708b2708f79e035e501079 Gerrit-Change-Number: 25576 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210927/fba9a4f6/attachment.htm>