Change in osmo-gbproxy[master]: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Sep 24 16:13:37 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577 )

Change subject: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1//COMMIT_MSG@12 
PS1, Line 12: 
why should it not "goto err_no_bvc" instead?

and why still use that for other code paths?


https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1/src/gb_proxy.c 
File src/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1/src/gb_proxy.c@1378 
PS1, Line 1378: 			break;
should it log an error here and/or increase the rate counter?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ic9f34a27412d6e15ca1198ee140f66a076b5c6b6
Gerrit-Change-Number: 25577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Sep 2021 16:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210924/3ba2b447/attachment.htm>


More information about the gerrit-log mailing list