Change in pysim[master]: pySim-prog: rename card_handler option to card_handler_config

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Sep 20 08:36:14 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25508 )

Change subject: pySim-prog: rename card_handler option to card_handler_config
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/25508/1/pySim-prog.py 
File pySim-prog.py:

https://gerrit.osmocom.org/c/pysim/+/25508/1/pySim-prog.py@203 
PS1, Line 203: 	parser.add_option("--card_handler_config", dest="card_handler_config", metavar="FILE",
I would keep "--card_handler" as argument name, just change the dest. Then people don't need to get used to the new name. IMHO the slightly confusing part was later with

  ch = CardHandlerAuto(sl, opts.card_handler)

vs the more readable

  ch = CardHandlerAuto(sl, opts.card_handler_config)



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If93751e815cb46f9ff3f56b54e612d77fe1a6dfd
Gerrit-Change-Number: 25508
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 20 Sep 2021 08:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210920/909d1362/attachment.htm>


More information about the gerrit-log mailing list