<p><a href="https://gerrit.osmocom.org/c/pysim/+/25508">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/25508/1/pySim-prog.py">File pySim-prog.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/25508/1/pySim-prog.py@203">Patch Set #1, Line 203:</a> <code style="font-family:monospace,monospace">      parser.add_option("--card_handler_config", dest="card_handler_config", metavar="FILE",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would keep "--card_handler" as argument name, just change the dest. Then people don't need to get used to the new name. IMHO the slightly confusing part was later with</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  ch = CardHandlerAuto(sl, opts.card_handler)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">vs the more readable</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  ch = CardHandlerAuto(sl, opts.card_handler_config)</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25508">change 25508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If93751e815cb46f9ff3f56b54e612d77fe1a6dfd </div>
<div style="display:none"> Gerrit-Change-Number: 25508 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 20 Sep 2021 08:36:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>