Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 9:

(3 comments)

See my proposal, this way the FSM is not affected, in the process of going through the list of addresses in order (it doesn't start from scratch).

https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/abis.c@218 
PS9, Line 218: 	priv->bsc_oml_host = bts->bsc_oml_hosts.next;
if (priv->bsc_oml_host == data) {
  if (llist_count() <= 1)
      priv->bsc_oml_host = NULL;
 else if (priv->bsc_oml_host == lllist_last())
      priv->bsc_oml_host = priv->bsc_oml_host.prev;
   else
      priv->bsc_oml_host = priv->bsc_oml_host.next;
}


https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c@530 
PS9, Line 530: 	if (bts->abis_link_fi)
This event can be dropped.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c@556 
PS9, Line 556: 			osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_CFG_CHANGE, NULL);
if (bts->abis_link_fi)
	osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_RM_ADDR, bsc_oml_host_del);
llist_del(&bsc_oml_host_del->list);
talloc_free(bsc_oml_host_del);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jul 2021 17:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/2ad1c2d3/attachment.htm>