<p style="white-space: pre-wrap; word-wrap: break-word;">See my proposal, this way the FSM is not affected, in the process of going through the list of addresses in order (it doesn't start from scratch).</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/abis.c">File src/common/abis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/abis.c@218">Patch Set #9, Line 218:</a> <code style="font-family:monospace,monospace">       priv->bsc_oml_host = bts->bsc_oml_hosts.next;</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (priv->bsc_oml_host == data) {<br>  if (llist_count() <= 1)<br>      priv->bsc_oml_host = NULL;<br> else if (priv->bsc_oml_host == lllist_last())<br>      priv->bsc_oml_host = priv->bsc_oml_host.prev;<br>   else<br>      priv->bsc_oml_host = priv->bsc_oml_host.next;<br>}</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c">File src/common/vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c@530">Patch Set #9, Line 530:</a> <code style="font-family:monospace,monospace">  if (bts->abis_link_fi)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This event can be dropped.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513/9/src/common/vty.c@556">Patch Set #9, Line 556:</a> <code style="font-family:monospace,monospace">                      osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_CFG_CHANGE, NULL);</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (bts->abis_link_fi)<br>        osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_RM_ADDR, bsc_oml_host_del);<br>llist_del(&bsc_oml_host_del->list);<br>talloc_free(bsc_oml_host_del);</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24513">change 24513</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24513"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727 </div>
<div style="display:none"> Gerrit-Change-Number: 24513 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 07 Jul 2021 17:43:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>