Change in osmo-sgsn[master]: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Jan 29 11:17:41 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 )

Change subject: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c 
File src/sgsn/sgsn_rim.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@49 
PS4, Line 49: 		retu
> I think this is correct (see spec ref below). […]
So this is checking the source address and returning an error. It seems the spec doesn't say anything about this case but since we would definitely reject the reply the status here seems fine to me.
One could also verify that the src address is actually routed back to the NSE that we received the message from but I'm not sure if there are uses where this assumption is violated.


https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@54 
PS4, Line 54: 		retu
> This should be correct as it is, done on BSSGP level. The spec says: […]
>From the little I read when looking at gbproxy support I'd agree that sending a BSSGP STATUS is correct.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I6fde8ab8955660b48000ca1b650cfc7c7b2e24ba
Gerrit-Change-Number: 22110
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jan 2021 11:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/437ca55a/attachment.htm>


More information about the gerrit-log mailing list