This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 ) Change subject: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c File src/sgsn/sgsn_rim.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@49 PS4, Line 49: retu > shouldn't we return a RIM-ERROR or RIM-APPLICATION-ERROR here? IMHO RIM is really one layer above/i […] I think this is correct (see spec ref below). Its probably a bit odd to say the address is invalid because we do not support GERAN, but I couldn't find a better cause code. Also I think that RIM-ERROR or RIM-APPLICATION-ERROR are used by the application to communicate errors. https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@54 PS4, Line 54: retu > likewise here. […] This should be correct as it is, done on BSSGP level. The spec says: 3GPP TS 48.018 8c.3.1.3 If an SGSN receives from a BSS a RIM PDU with an invalid destination address, the PDU shall be discarded and a STATUS PDU with the cause value set to "Unknown Destination address" shall be sent back to the BSS. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6fde8ab8955660b48000ca1b650cfc7c7b2e24ba Gerrit-Change-Number: 22110 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 25 Jan 2021 22:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210125/87483647/attachment.htm>