Change in osmo-sgsn[master]: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 29 21:31:53 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 )

Change subject: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c 
File src/sgsn/sgsn_rim.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@49 
PS4, Line 49: 		retu
> So this is checking the source address and returning an error. […]
Sorry, I was thinking about the gbproxy case when reading this.  But it's the SGSN code.  Of course we cannot support any source != GERAN arriving from the Gb side.


https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@54 
PS4, Line 54: 		retu
> From the little I read when looking at gbproxy support I'd agree that sending a BSSGP STATUS is corr […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I6fde8ab8955660b48000ca1b650cfc7c7b2e24ba
Gerrit-Change-Number: 22110
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jan 2021 21:31:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/c0e2fd8e/attachment.htm>


More information about the gerrit-log mailing list