This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/22311 ) Change subject: Add vty command to show summary of all or filtered subscribers ...................................................................... Patch Set 7: (4 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@232 PS7, Line 232: vty_out(vty, "----- ------------ ---------------- ---------------- -----"); : if (show_ls) : vty_out(vty, " ------------"); : vty_out_newline(vty); : vty_out(vty, "ID MSISDN IMSI IMEI NAM"); : if (show_ls) : vty_out(vty, " LAST SEEN"); : vty_out_newline(vty); > Well, it is and it isn't... the first one has the text above the lines.. the footer is reversed. […] yes, please go for that function, if required with reversed lines. Or two separate functions that you call in different order. I just don't want to see those strings copy+pasted at two locations. https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@251 PS7, Line 251: SUBSCR_SHOW_HELP > Yeah, I think this can be optimised more, but I was not sure as it does get hard to read. works for me. https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@320 PS7, Line 320: > Ah, I messed up somewhere.. […] This doesn't make sense: show -> SHOW_STR subscribers -> SUBSCR_SHOW_HELP cs -> Show summary of all Subscribers ps -> Show Subscribers with NAM CS In/active on -> Show Subscribers with NAM PS In/active\n" off -> no help even if you remove the "Show summary of all Subscribers" string (it is not "all", after all) then still you are missing the ON/OFF help. https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@323 PS7, Line 323: last seen > Yes. […] I personally don't think there are other tokens after last and hence would like to see last-seen. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/22311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7f0573381a6d0d13841ac6d42d50f0e8389decf4 Gerrit-Change-Number: 22311 Gerrit-PatchSet: 7 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jan 2021 21:55:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210120/0724c0e8/attachment.htm>