<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c">File src/hlr_vty_subscr.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@232">Patch Set #7, Line 232:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty_out(vty, "----- ------------ ---------------- ---------------- -----");<br> if (show_ls)<br> vty_out(vty, " ------------");<br> vty_out_newline(vty);<br> vty_out(vty, "ID MSISDN IMSI IMEI NAM");<br> if (show_ls)<br> vty_out(vty, " LAST SEEN");<br> vty_out_newline(vty);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Well, it is and it isn't... the first one has the text above the lines.. the footer is reversed. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">yes, please go for that function, if required with reversed lines. Or two separate functions that you call in different order. I just don't want to see those strings copy+pasted at two locations.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@251">Patch Set #7, Line 251:</a> <code style="font-family:monospace,monospace">SUBSCR_SHOW_HELP</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Yeah, I think this can be optimised more, but I was not sure as it does get hard to read.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">works for me.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@320">Patch Set #7, Line 320:</a> <code style="font-family:monospace,monospace"> </code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ah, I messed up somewhere.. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This doesn't make sense:</p><p style="white-space: pre-wrap; word-wrap: break-word;">show -> SHOW_STR<br>subscribers -> SUBSCR_SHOW_HELP<br>cs -> Show summary of all Subscribers<br>ps -> Show Subscribers with NAM CS In/active<br>on -> Show Subscribers with NAM PS In/active\n"<br>off -> no help</p><p style="white-space: pre-wrap; word-wrap: break-word;">even if you remove the "Show summary of all Subscribers" string (it is not "all", after all) then still you are missing the ON/OFF help.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@323">Patch Set #7, Line 323:</a> <code style="font-family:monospace,monospace">last seen</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Yes. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I personally don't think there are other tokens after last and hence would like to see last-seen.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311">change 22311</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/22311"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7f0573381a6d0d13841ac6d42d50f0e8389decf4 </div>
<div style="display:none"> Gerrit-Change-Number: 22311 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jan 2021 21:55:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>