Change in osmo-hlr[master]: Add vty command to show summary of all or filtered subscribers

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/22311 )

Change subject: Add vty command to show summary of all or filtered subscribers
......................................................................


Patch Set 7:

(6 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/db_hlr.c 
File src/db_hlr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/db_hlr.c@633 
PS7, Line 633:  
> it's now called get_cb? 'data' is missing.
meh, sorry. forgot to update these..


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c 
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@232 
PS7, Line 232: vty_out(vty, "-----  ------------  ----------------  ----------------  -----");
             : 		if (show_ls)
             : 			vty_out(vty, "  ------------");
             : 		vty_out_newline(vty);
             : 		vty_out(vty, "ID     MSISDN        IMSI              IMEI              NAM");
             : 		if (show_ls)
             : 			vty_out(vty, "    LAST SEEN");
             : 		vty_out_newline(vty);
> thisi s a repetition of the above. […]
Well, it is and it isn't... the first one has the text above the lines.. the footer is reversed. But far too much attention to visual detail maybe?
I guess the function could accept a header/footer arg and reverse the output based on this..


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@251 
PS7, Line 251: SUBSCR_SHOW_HELP
> you could add the SHOW_STR inside the definition of SUBSCR_SHOW_HELP, so you don't have to repeat it […]
Yeah, I think this can be optimised more, but I was not sure as it does get hard to read.


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@305 
PS7, Line 305: SHOW_STR SUBSCRS_SHOW_HELP "Show summary of subscribers with filter\n"
             :       "Filter by IMSI\n" "Filter by MSISDN\n" "String to match in msisdn or imsi\n")
> it's odd that the command syntax is hidden in a #define whle the help strings are not. […]
My understanding of the existing logic (the code before I edited it) was that anything appearing more than once was #define'd and anything appearing ONLY ONCE was just strings in the DEFUN. It seemed to make sense as eliminates duplication. I tried to follow the same logic.


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@320 
PS7, Line 320:      
> Somehow the number of help strings doesn't match the number of tokens. […]
Ah, I messed up somewhere..

Which part does not make sense? The way I wrote In/Active?


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@323 
PS7, Line 323: last seen
> if you do not expect other tokens after "last" (like "last created" or whatever), then please change […]
Yes. I guess it would be nice to get some feedback on anything people might like to see here, so it could be integrated in this patch set.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/22311
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I7f0573381a6d0d13841ac6d42d50f0e8389decf4
Gerrit-Change-Number: 22311
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jan 2021 20:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210120/5611f937/attachment.htm>