Change in osmo-trx[master]: Transceiver: explicitly init m{Rx, Tx}LowerLoopThread

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20879 )

Change subject: Transceiver: explicitly init m{Rx,Tx}LowerLoopThread
......................................................................

Transceiver: explicitly init m{Rx,Tx}LowerLoopThread

Coverity warns us that a non-static class members:

  - mRxLowerLoopThread, and
  - mTxLowerLoopThread,

are not initialized in this constructor nor in any functions that
it calls.  I don't think it's critical, because we do initialize
them in Transceiver::start(), but let's make them nullptr.

Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf
Fixes: CID#214952
---
M Transceiver52M/Transceiver.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 881633e..4980861 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -136,6 +136,7 @@
                          GSM::Time wTransmitLatency,
                          RadioInterface *wRadioInterface)
   : cfg(cfg), mClockSocket(-1),
+    mRxLowerLoopThread(nullptr), mTxLowerLoopThread(nullptr),
     mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface),
     mChans(cfg->num_chans), mOn(false), mForceClockInterface(false),
     mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0),

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20879
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf
Gerrit-Change-Number: 20879
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201028/152a33da/attachment.htm>