<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20879">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: explicitly init m{Rx,Tx}LowerLoopThread<br><br>Coverity warns us that a non-static class members:<br><br>  - mRxLowerLoopThread, and<br>  - mTxLowerLoopThread,<br><br>are not initialized in this constructor nor in any functions that<br>it calls.  I don't think it's critical, because we do initialize<br>them in Transceiver::start(), but let's make them nullptr.<br><br>Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf<br>Fixes: CID#214952<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 881633e..4980861 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -136,6 +136,7 @@</span><br><span>                          GSM::Time wTransmitLatency,</span><br><span>                          RadioInterface *wRadioInterface)</span><br><span>   : cfg(cfg), mClockSocket(-1),</span><br><span style="color: hsl(120, 100%, 40%);">+    mRxLowerLoopThread(nullptr), mTxLowerLoopThread(nullptr),</span><br><span>     mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface),</span><br><span>     mChans(cfg->num_chans), mOn(false), mForceClockInterface(false),</span><br><span>     mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/20879">change 20879</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/20879"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf </div>
<div style="display:none"> Gerrit-Change-Number: 20879 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>