Change in osmocom-bb[master]: tpu: Fix msgb-write-beyond-tailroom in TPU_DEBUG

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Oct 24 10:37:37 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20880 )


Change subject: tpu: Fix msgb-write-beyond-tailroom in TPU_DEBUG
......................................................................

tpu: Fix msgb-write-beyond-tailroom in TPU_DEBUG

We need to make sure to allocte sufficient space to include
the 32bit frame number at the start of the TPU_DEBUG msgb.

Change-Id: Ifb3ce6f91131fc361b20c3b3fe5ebc7079633ac3
---
M src/target/firmware/calypso/tpu.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/80/20880/1

diff --git a/src/target/firmware/calypso/tpu.c b/src/target/firmware/calypso/tpu.c
index 0b60292..f778bfd 100644
--- a/src/target/firmware/calypso/tpu.c
+++ b/src/target/firmware/calypso/tpu.c
@@ -91,7 +91,7 @@
 {
 	uint16_t *tpu_base = (uint16_t *)BASE_ADDR_TPU_RAM;
 	unsigned int tpu_size = tpu_ptr - tpu_base;
-	struct msgb *msg = sercomm_alloc_msgb(tpu_size*2);
+	struct msgb *msg = sercomm_alloc_msgb(sizeof(uint32_t) + tpu_size*2);
 	uint16_t *data;
 	uint32_t *fn;
 	uint16_t reg;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20880
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifb3ce6f91131fc361b20c3b3fe5ebc7079633ac3
Gerrit-Change-Number: 20880
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201024/783a0528/attachment.htm>


More information about the gerrit-log mailing list