Change in osmo-trx[master]: Transceiver: Pass config struct instead of large list of params

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20638 )

Change subject: Transceiver: Pass config struct instead of large list of params
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/CommonLibs/trx_vty.h 
File CommonLibs/trx_vty.h:

https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/CommonLibs/trx_vty.h@47 
PS1, Line 47: struct trx_cfg
In general, this stricture (together with the other definitions in this file) is not something VTY specific, so I believe 'CommonLibs/config_defs.h' is a better place. If we move them there, there will be no need to #include <trx_vty.h> in Transceiver.{c,h}, which has nothing to do with the VTY.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb43cb11f3e7a69b0a88f632f0a0c90ada7f939e
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Oct 2020 19:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/c132dca2/attachment.htm>