Change in osmo-trx[master]: Transceiver: Pass config struct instead of large list of params

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 14 10:42:11 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20638 )

Change subject: Transceiver: Pass config struct instead of large list of params
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h 
File Transceiver52M/Transceiver.h:

https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@111 
PS1, Line 111:               //const char *TRXAddress,
> Any reason why you're keeping the old arguments commented out?
I forgot to drop those, I'll drop them.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb43cb11f3e7a69b0a88f632f0a0c90ada7f939e
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Oct 2020 10:42:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201014/0b8ddb69/attachment.htm>


More information about the gerrit-log mailing list