This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20638 ) Change subject: Transceiver: Pass config struct instead of large list of params ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@110 PS1, Line 110: struct Can we use 'const' here? If yes, let's use it. https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@111 PS1, Line 111: //const char *TRXAddress, Any reason why you're keeping the old arguments commented out? https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@158 PS1, Line 158: struct Same here, 'const' if possible. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ifb43cb11f3e7a69b0a88f632f0a0c90ada7f939e Gerrit-Change-Number: 20638 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2020 19:45:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/e136c103/attachment.htm>