<p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h">File Transceiver52M/Transceiver.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@110">Patch Set #1, Line 110:</a> <code style="font-family:monospace,monospace">struct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we use 'const' here? If yes, let's use it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@111">Patch Set #1, Line 111:</a> <code style="font-family:monospace,monospace">              //const char *TRXAddress,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Any reason why you're keeping the old arguments commented out?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638/1/Transceiver52M/Transceiver.h@158">Patch Set #1, Line 158:</a> <code style="font-family:monospace,monospace">struct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, 'const' if possible.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/20638">change 20638</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/20638"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb43cb11f3e7a69b0a88f632f0a0c90ada7f939e </div>
<div style="display:none"> Gerrit-Change-Number: 20638 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 13 Oct 2020 19:45:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>