Change in osmo-bts[master]: trx: Fix reported BER for TCH/H

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/17565 )


Change subject: trx: Fix reported BER for TCH/H
......................................................................

trx: Fix reported BER for TCH/H

This fixes a regression introduced in I710d0b7cf193afa8515807836ee69b8b7db84a84

We (obviously!) cannot compute the BER before performing convolutional
decoding.

Change-Id: I4e57f45d49cb513e4843e56f50c8de6980958fdc
Related: OS#2977
Related: OS#4667
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/17565/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index d703f7f..585e887 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1375,13 +1375,12 @@
 	}
 	*mask = 0x0;
 
-        ber10k = compute_ber10k(n_bits_total, n_errors);
-
 	/* skip second of two TCH frames of FACCH was received */
 	if (chan_state->ul_ongoing_facch) {
 		chan_state->ul_ongoing_facch = 0;
 		memcpy(*bursts_p, *bursts_p + 232, 232);
 		memcpy(*bursts_p + 232, *bursts_p + 464, 232);
+		ber10k = 0;
 		goto bfi;
 	}
 
@@ -1428,6 +1427,8 @@
 	}
 	memcpy(*bursts_p, *bursts_p + 232, 232);
 	memcpy(*bursts_p + 232, *bursts_p + 464, 232);
+	ber10k = compute_ber10k(n_bits_total, n_errors);
+
 
 	/* Check if the frame is bad */
 	if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4e57f45d49cb513e4843e56f50c8de6980958fdc
Gerrit-Change-Number: 17565
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200322/dd4cac01/attachment.htm>