This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17564 ) Change subject: osmo-sim-test: Avoid double-close ...................................................................... osmo-sim-test: Avoid double-close Change-Id: Ibd67a5461085a77dd9e804a4f1266d67ee91a04a Closes: CID#208960 --- M utils/osmo-sim-test.c 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c index 6cf36a6..cf423c4 100644 --- a/utils/osmo-sim-test.c +++ b/utils/osmo-sim-test.c @@ -421,11 +421,8 @@ break; case EF_TYPE_TRANSP: if (g_class != 0xA0) { - if (!TLVP_PRESENT(&tp, UICC_FCP_T_FILE_SIZE)) { - if (f_data) - fclose(f_data); + if (!TLVP_PRESENT(&tp, UICC_FCP_T_FILE_SIZE)) goto out; - } i = ntohs(*(uint16_t *)TLVP_VAL(&tp, UICC_FCP_T_FILE_SIZE)); printf("File size: %d bytes\n", i); } else { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd67a5461085a77dd9e804a4f1266d67ee91a04a Gerrit-Change-Number: 17564 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200322/bbaa2235/attachment.htm>