<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17565">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx: Fix reported BER for TCH/H<br><br>This fixes a regression introduced in I710d0b7cf193afa8515807836ee69b8b7db84a84<br><br>We (obviously!) cannot compute the BER before performing convolutional<br>decoding.<br><br>Change-Id: I4e57f45d49cb513e4843e56f50c8de6980958fdc<br>Related: OS#2977<br>Related: OS#4667<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/17565/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index d703f7f..585e887 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -1375,13 +1375,12 @@</span><br><span>      }</span><br><span>    *mask = 0x0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        ber10k = compute_ber10k(n_bits_total, n_errors);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     /* skip second of two TCH frames of FACCH was received */</span><br><span>    if (chan_state->ul_ongoing_facch) {</span><br><span>               chan_state->ul_ongoing_facch = 0;</span><br><span>                 memcpy(*bursts_p, *bursts_p + 232, 232);</span><br><span>             memcpy(*bursts_p + 232, *bursts_p + 464, 232);</span><br><span style="color: hsl(120, 100%, 40%);">+                ber10k = 0;</span><br><span>          goto bfi;</span><br><span>    }</span><br><span> </span><br><span>@@ -1428,6 +1427,8 @@</span><br><span>        }</span><br><span>    memcpy(*bursts_p, *bursts_p + 232, 232);</span><br><span>     memcpy(*bursts_p + 232, *bursts_p + 464, 232);</span><br><span style="color: hsl(120, 100%, 40%);">+        ber10k = compute_ber10k(n_bits_total, n_errors);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span>       /* Check if the frame is bad */</span><br><span>      if (rc < 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17565">change 17565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4e57f45d49cb513e4843e56f50c8de6980958fdc </div>
<div style="display:none"> Gerrit-Change-Number: 17565 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>