Change in osmo-bts[master]: osmo-bts-virtual: do not print redundant info in tx_to_virt_um()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17299 )

Change subject: osmo-bts-virtual: do not print redundant info in tx_to_virt_um()
......................................................................

osmo-bts-virtual: do not print redundant info in tx_to_virt_um()

LOGL1S() already prints enough context information.

Change-Id: I29adf9360b96544b7f58766d5cd26d97117884d9
---
M src/osmo-bts-virtual/scheduler_virtbts.c
1 file changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c
index fef367b..91d9153 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -46,16 +46,6 @@
 
 #define MODULO_HYPERFRAME 0
 
-static const char *gsmtap_hdr_stringify(const struct gsmtap_hdr *gh)
-{
-	static char buf[256];
-	snprintf(buf, sizeof(buf), "(ARFCN=%u, ts=%u, ss=%u, type=%u/%u)",
-		 ntohs(gh->arfcn & GSMTAP_ARFCN_MASK),
-		 gh->timeslot, gh->sub_slot,
-		 gh->type, gh->sub_type);
-	return buf;
-}
-
 /**
  * Send a message over the virtual um interface.
  * This will at first wrap the msg with a GSMTAP header and then write it to the declared multicast socket.
@@ -96,18 +86,17 @@
 
 	if (outmsg) {
 		struct phy_instance *pinst = trx_phy_instance(l1t->trx);
-		struct gsmtap_hdr *gh = (struct gsmtap_hdr *)msgb_data(outmsg);
 		int rc;
 
 		rc = virt_um_write_msg(pinst->phy_link->u.virt.virt_um, outmsg);
 		if (rc < 0)
 			LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn,
-				"%s GSMTAP msg could not send to virtual Um\n", gsmtap_hdr_stringify(gh));
+			       "GSMTAP msg could not send to virtual Um\n");
 		else if (rc == 0)
 			bts_shutdown(l1t->trx->bts, "VirtPHY write socket died\n");
 		else
 			LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn,
-				"%s Sending GSMTAP message to virtual Um\n", gsmtap_hdr_stringify(gh));
+			       "Sending GSMTAP message to virtual Um\n");
 	} else
 		LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "GSMTAP msg could not be created!\n");
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17299
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I29adf9360b96544b7f58766d5cd26d97117884d9
Gerrit-Change-Number: 17299
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200301/8299da88/attachment.htm>