Change in osmo-bts[master]: osmo-bts-virtual: do not log GSMTAP message sending failure twice

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun Mar 1 17:14:50 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17300 )

Change subject: osmo-bts-virtual: do not log GSMTAP message sending failure twice
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/17300/1/src/osmo-bts-virtual/scheduler_virtbts.c 
File src/osmo-bts-virtual/scheduler_virtbts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17300/1/src/osmo-bts-virtual/scheduler_virtbts.c@95 
PS1, Line 95: 			       "GSMTAP msg could not send to virtual Um: %s\n",
I'd rather return errno as -errno in virt_um_write_msg() and avoid using errno at this level.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17300
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I39e9edf35240ef31e3432412b459c2b8fb0de054
Gerrit-Change-Number: 17300
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 01 Mar 2020 17:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200301/9acbd499/attachment.htm>


More information about the gerrit-log mailing list