<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17299">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-virtual: do not print redundant info in tx_to_virt_um()<br><br>LOGL1S() already prints enough context information.<br><br>Change-Id: I29adf9360b96544b7f58766d5cd26d97117884d9<br>---<br>M src/osmo-bts-virtual/scheduler_virtbts.c<br>1 file changed, 2 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>index fef367b..91d9153 100644</span><br><span>--- a/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>+++ b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>@@ -46,16 +46,6 @@</span><br><span> </span><br><span> #define MODULO_HYPERFRAME 0</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static const char *gsmtap_hdr_stringify(const struct gsmtap_hdr *gh)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-       static char buf[256];</span><br><span style="color: hsl(0, 100%, 40%);">-   snprintf(buf, sizeof(buf), "(ARFCN=%u, ts=%u, ss=%u, type=%u/%u)",</span><br><span style="color: hsl(0, 100%, 40%);">-             ntohs(gh->arfcn & GSMTAP_ARFCN_MASK),</span><br><span style="color: hsl(0, 100%, 40%);">-            gh->timeslot, gh->sub_slot,</span><br><span style="color: hsl(0, 100%, 40%);">-               gh->type, gh->sub_type);</span><br><span style="color: hsl(0, 100%, 40%);">- return buf;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /**</span><br><span>  * Send a message over the virtual um interface.</span><br><span>  * This will at first wrap the msg with a GSMTAP header and then write it to the declared multicast socket.</span><br><span>@@ -96,18 +86,17 @@</span><br><span> </span><br><span>     if (outmsg) {</span><br><span>                struct phy_instance *pinst = trx_phy_instance(l1t->trx);</span><br><span style="color: hsl(0, 100%, 40%);">-             struct gsmtap_hdr *gh = (struct gsmtap_hdr *)msgb_data(outmsg);</span><br><span>              int rc;</span><br><span> </span><br><span>          rc = virt_um_write_msg(pinst->phy_link->u.virt.virt_um, outmsg);</span><br><span>               if (rc < 0)</span><br><span>                       LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn,</span><br><span style="color: hsl(0, 100%, 40%);">-                             "%s GSMTAP msg could not send to virtual Um\n", gsmtap_hdr_stringify(gh));</span><br><span style="color: hsl(120, 100%, 40%);">+                         "GSMTAP msg could not send to virtual Um\n");</span><br><span>               else if (rc == 0)</span><br><span>                    bts_shutdown(l1t->trx->bts, "VirtPHY write socket died\n");</span><br><span>          else</span><br><span>                         LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn,</span><br><span style="color: hsl(0, 100%, 40%);">-                             "%s Sending GSMTAP message to virtual Um\n", gsmtap_hdr_stringify(gh));</span><br><span style="color: hsl(120, 100%, 40%);">+                            "Sending GSMTAP message to virtual Um\n");</span><br><span>  } else</span><br><span>               LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "GSMTAP msg could not be created!\n");</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17299">change 17299</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17299"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I29adf9360b96544b7f58766d5cd26d97117884d9 </div>
<div style="display:none"> Gerrit-Change-Number: 17299 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>