Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor UL burst measurement processing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 23 11:44:57 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18973 )

Change subject: osmo-bts-trx/scheduler: refactor UL burst measurement processing
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/include/osmo-bts/scheduler.h 
File include/osmo-bts/scheduler.h:

https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/include/osmo-bts/scheduler.h@132 
PS2, Line 132: 		unsigned int idx;
> missing documentation for this field idx (not lear what's its purpose).
Well, it's a part of the ring buffer. I can move it upwards before the 'struct'.


https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/sched_lchan_tchf.c@203 
PS2, Line 203: 	 * TODO: properly handle measurements in DTX mode */
> Is this adding a regression?
No, it's just a reminder that dexter's change (next one) is going to fix this.


https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@377 
PS2, Line 377: 	unsigned int current = chan_state->meas.idx;
> so idx points to the next "free" slot. […]
Well, it's not really 'next', rather 'current'. I can rename it.


https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@413 
PS2, Line 413: 		n = 6; shift = n;
> So you are keeping both n and shift having same value and they don't change later. […]
See next change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2b02b51fea5664f161382a4ddc63dbf14ffc9ac5
Gerrit-Change-Number: 18973
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 11:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/6e4edff9/attachment.htm>


More information about the gerrit-log mailing list