<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/include/osmo-bts/scheduler.h">File include/osmo-bts/scheduler.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/include/osmo-bts/scheduler.h@132">Patch Set #2, Line 132:</a> <code style="font-family:monospace,monospace"> unsigned int idx;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">missing documentation for this field idx (not lear what's its purpose).</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Well, it's a part of the ring buffer. I can move it upwards before the 'struct'.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/sched_lchan_tchf.c">File src/osmo-bts-trx/sched_lchan_tchf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/sched_lchan_tchf.c@203">Patch Set #2, Line 203:</a> <code style="font-family:monospace,monospace"> * TODO: properly handle measurements in DTX mode */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Is this adding a regression?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">No, it's just a reminder that dexter's change (next one) is going to fix this.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c">File src/osmo-bts-trx/scheduler_trx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@377">Patch Set #2, Line 377:</a> <code style="font-family:monospace,monospace"> unsigned int current = chan_state->meas.idx;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">so idx points to the next "free" slot. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Well, it's not really 'next', rather 'current'. I can rename it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@413">Patch Set #2, Line 413:</a> <code style="font-family:monospace,monospace"> n = 6; shift = n;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">So you are keeping both n and shift having same value and they don't change later. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">See next change.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18973">change 18973</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18973"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b02b51fea5664f161382a4ddc63dbf14ffc9ac5 </div>
<div style="display:none"> Gerrit-Change-Number: 18973 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Jun 2020 11:44:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>