This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18973 )
Change subject: osmo-bts-trx/scheduler: refactor UL burst measurement processing
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@405
PS2, Line 405: n = 4; shift = n;
(style wise i'd either put each in a separate line or do shift = n = 4)
https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@421
PS2, Line 421: for (i = 0; i < n; i++) {
how are you sure that all n slots of the ring buffer have actually been populated by values?
https://gerrit.osmocom.org/c/osmo-bts/+/18973/2/src/osmo-bts-trx/scheduler_trx.c@432
PS2, Line 432: .rssi = (rssi_sum / n),
(wondering whether this should rather round() than this trunc())
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2b02b51fea5664f161382a4ddc63dbf14ffc9ac5
Gerrit-Change-Number: 18973
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 20:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/596f00ba/attachment.htm>