Change in osmo-trx[master]: UHDDevice: Compute TxGain on UHD API based on expected Tx output power

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 )

Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power
......................................................................


Patch Set 3: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h 
File Transceiver52M/device/uhd/UHDDevice.h:

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h@139 
PS3, Line 139: 	double maxTxGain(void) { OSMO_ASSERT(false); return 0.0f; };
it seems you should rather completely remove these functions, especially since they are private?
...oh wait, inheritance, right?


https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp 
File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@218 
PS3, Line 218: static double TxGain2TxPower(dev_band_desc& desc, double tx_gain_db)
const dev_band_desc

(typically the '&' sticks to the variable name, not the type. Like above: "const std::string &msg")


https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@222 
PS3, Line 222: static double TxPower2TxGain(dev_band_desc& desc, double tx_power_dbm)
same


https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@1054 
PS3, Line 1054: 	band = req_band;
(this logging seems nice to have? why drop it?)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43
Gerrit-Change-Number: 18723
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 14 Jun 2020 11:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200614/3a232a8d/attachment.htm>