<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h">File Transceiver52M/device/uhd/UHDDevice.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h@139">Patch Set #3, Line 139:</a> <code style="font-family:monospace,monospace">  double maxTxGain(void) { OSMO_ASSERT(false); return 0.0f; };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">it seems you should rather completely remove these functions, especially since they are private?<br>...oh wait, inheritance, right?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp">File Transceiver52M/device/uhd/UHDDevice.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@218">Patch Set #3, Line 218:</a> <code style="font-family:monospace,monospace">static double TxGain2TxPower(dev_band_desc& desc, double tx_gain_db)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">const dev_band_desc</p><p style="white-space: pre-wrap; word-wrap: break-word;">(typically the '&' sticks to the variable name, not the type. Like above: "const std::string &msg")</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@222">Patch Set #3, Line 222:</a> <code style="font-family:monospace,monospace">static double TxPower2TxGain(dev_band_desc& desc, double tx_power_dbm)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@1054">Patch Set #3, Line 1054:</a> <code style="font-family:monospace,monospace">       band = req_band;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">(this logging seems nice to have? why drop it?)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/18723">change 18723</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/18723"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43 </div>
<div style="display:none"> Gerrit-Change-Number: 18723 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: roh <jsteiger@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 14 Jun 2020 11:49:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>