Change in osmo-trx[master]: UHDDevice: Compute TxGain on UHD API based on expected Tx output power

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 15 08:40:07 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 )

Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h 
File Transceiver52M/device/uhd/UHDDevice.h:

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.h@139 
PS3, Line 139: 	double maxTxGain(void) { OSMO_ASSERT(false); return 0.0f; };
> it seems you should rather completely remove these functions, especially since they are private? […]
indeed, inheritance, other devices still use them.


https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp 
File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/18723/3/Transceiver52M/device/uhd/UHDDevice.cpp@1054 
PS3, Line 1054: 	band = req_band;
> (this logging seems nice to have? why drop it?)
Because global variable tx_gain_max doesn't exist anymore, and related logic moved to others parts in the file.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43
Gerrit-Change-Number: 18723
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 08:40:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/6adb931d/attachment.htm>


More information about the gerrit-log mailing list