Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 )

Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type
......................................................................

vlr_subscr_rx_id_resp(): dont assert on received MI type

The Mobile Identity type is received on the wire, we asserting on its type
constitutes a DoS vector.

Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0
---
M src/libvlr/vlr.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 887ceb8..019e657 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1146,6 +1146,8 @@
 	case GSM_MI_TYPE_IMEISV:
 		vlr_subscr_set_imeisv(vsub, mi_string);
 		break;
+	default:
+		return -EINVAL;
 	}
 
 	if (vsub->auth_fsm) {
@@ -1170,8 +1172,7 @@
 			event = VLR_ULA_E_ID_IMEISV;
 			break;
 		default:
-			OSMO_ASSERT(0);
-			break;
+			return -EINVAL;
 		}
 		osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18635
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0
Gerrit-Change-Number: 18635
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/aa6f02f4/attachment.htm>