<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/18635">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vlr_subscr_rx_id_resp(): dont assert on received MI type<br><br>The Mobile Identity type is received on the wire, we asserting on its type<br>constitutes a DoS vector.<br><br>Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0<br>---<br>M src/libvlr/vlr.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c</span><br><span>index 887ceb8..019e657 100644</span><br><span>--- a/src/libvlr/vlr.c</span><br><span>+++ b/src/libvlr/vlr.c</span><br><span>@@ -1146,6 +1146,8 @@</span><br><span>    case GSM_MI_TYPE_IMEISV:</span><br><span>             vlr_subscr_set_imeisv(vsub, mi_string);</span><br><span>              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span>        if (vsub->auth_fsm) {</span><br><span>@@ -1170,8 +1172,7 @@</span><br><span>                     event = VLR_ULA_E_ID_IMEISV;</span><br><span>                         break;</span><br><span>               default:</span><br><span style="color: hsl(0, 100%, 40%);">-                        OSMO_ASSERT(0);</span><br><span style="color: hsl(0, 100%, 40%);">-                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+                        return -EINVAL;</span><br><span>              }</span><br><span>            osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string);</span><br><span>   }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/18635">change 18635</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/18635"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0 </div>
<div style="display:none"> Gerrit-Change-Number: 18635 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>