This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/18635/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/18635/1/src/libvlr/vlr.c@1175 PS1, Line 1175: return -EINVAL; > AFAIU since you return above in this caase, you can drop the default case altogether here. yea I know, doing this mostly for coverity "you haven't dealt with all enum values" (though this isn't an enum, come to think of it), but also for paranoia of future changes. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0 Gerrit-Change-Number: 18635 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2020 15:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/3e62b28e/attachment.htm>