Change in libosmocore[master]: vty: Introduce support to set cpu-affinity and scheduler policy

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19442 )

Change subject: vty: Introduce support to set cpu-affinity and scheduler policy
......................................................................


Patch Set 3: Code-Review-1

(11 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c 
File src/vty/sched_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@279 
PS3, Line 279: "Set CPU affinity mask of the thread\n"
This description only applies to 'self', while the rest ('all', 'THREADNAME', '<0-4294967295>') is not documented. Each '(x|y|z)' entry needs a separate doc-string. Please make sure to add the VTY node tests (see tdef/tdef_vty_test_dynamic.vty, for example).


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@315 
PS3, Line 315: parsing
Maybe s/parsing/to parse/?


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@323 
PS3, Line 323: setting
Same here.


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@361 
PS3, Line 361: memset(&param, 0, sizeof(param));
             : 	param.sched_priority = prio;
Cosmetic: could be ... param = { .prio = 0 };


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@377 
PS3, Line 377: Use
Set?


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@378 
PS3, Line 378: Real time priority
Something also looks wrong here: you have three patterns in "policy rr <1-32>", but there are four help messages?


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@430 
PS3, Line 430: if(
coding style


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@434 
PS3, Line 434: (long int)mypid, (long int) tid_it)
cosmetic: inconsistent spacing


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@452 
PS3, Line 452: (1 << cpu_i);
UBSan usually warns that this needs to be explicitly casted to typeof(mask), because AFAIU by default (1 << x) is an integer of the platform specific size.


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@484 
PS3, Line 484: vty
Doxygen: 'vty' (no such parameter) vs 'tall_ctx'


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@487 
PS3, Line 487: int
void? You always return 0 anyway...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76a4bd2cc7b3c7adf5d84790a944d78be70e10a
Gerrit-Change-Number: 19442
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 29 Jul 2020 22:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/fed64fbb/attachment.htm>