Change in libosmocore[master]: vty: Introduce support to set cpu-affinity and scheduler policy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 30 14:41:42 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19442 )

Change subject: vty: Introduce support to set cpu-affinity and scheduler policy
......................................................................


Patch Set 3:

(2 comments)

I'm fine with not using numeric ranges to specify the mask since I understand I'm limited to 64 cpus there, I'll use a variable for that and parse it manually as a string, but I still want to define the cpuset as a hexstring, which is a usual known way of expressing it (see taskset cmd for instance).

https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c 
File src/vty/sched_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@121 
PS3, Line 121: 	char path[100];
> why not PATH_MAX?
Because it's clearly not needed, the path length is more or less known (with a few variables like name being 1-15 chars, and TID+PID being 1-20 each aprox.


https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@487 
PS3, Line 487: int
> void? You always return 0 anyway...
Currently only returns only 0, but who knows if extending implementation/commands here in the future would require returning an error. So let's keep it this way to prevent API breakage in the future.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76a4bd2cc7b3c7adf5d84790a944d78be70e10a
Gerrit-Change-Number: 19442
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jul 2020 14:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/01e3fe73/attachment.htm>


More information about the gerrit-log mailing list